RE: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)
-----Original Message-----
From: Daniel Veillard [mailto:veillard@redhat.com]
Looks overall fine to me, the syntactic construct sounds generic
enough.
I would still suggest 2 more changes:
- in virDomainGraphicsDefParseXML check the values coming from
the XML, I guess we should accept only "true" and "false"
and raise an error, otherwise one may pass --fullscreen=foo
on the command line !
[IH] the qemu command line can only have -full-screen
if the attribute is
true, no other option, but I can lookup the code checking the input you
mentioned.
- drop stdbool.h and use int instead of bool, this doesn't
really
gain anything and causes some troubles (e.g. with CIL)
[IH] I was just trying
to follow the exiting conventions in the code...
see src/cgroup.c
Which should it be?
Also if you could set your mail agent to set a mime-type of text/plain
on the diff or patch attachemnts, that would allow to comment them
in-line, which allows for faster feedback loop in the future.
[IH] will try to remember for patches.
thanks :-) !
Daniel