Re: [libvirt] [PATCH v2 0/6] Allow adding mountOpts to the storage pool mount command
On 1/9/19 11:55 AM, Michal Privoznik wrote:
[...]
ACK
Thanks for the review... although it seems I'll have to consider a 3rd
approach as a result of Daniel's comments. Nothing is ever easy.
My only worry is that we don't validate the options in any way.
They are
basically a text free form which we will put onto 'mount' cmd line directly.
I thought about making sure of specific chars for the attributes (there
are some examples in other .rng files), but I know as soon as I do,
there's some request for some char that wasn't included. Going with
<text/> was just the bail out especially since I find regex's to be
unintelligible to fully decipher.
John