Re: [libvirt] [PATCH 10/11] Improve SCSI volume key and name generation

On 11/12/2010 07:45 PM, Daniel P. Berrange wrote: >On Fri, Nov 12, 2010 at 07:32:05PM +0100, Paolo Bonzini wrote: >>On 11/12/2010 05:22 PM, Daniel P. Berrange wrote: >>>+{ >>>+ const char *cmdargv[] = { >>>+ "/lib/udev/scsi_id", >>>+ "--replace-whitespace", >>>+ "--whitelisted", >>>+ "--device", dev, >>>+ NULL >>>+ }; >> >>Does this needs to be "/lib/udev/scsi_id -gud<dev>" for RHEL5 >>compatibility? However, I can only get "scsi_id -gus /block/sda" to >>work on my RHEL5 installation, not "scsi_id -gud /dev/sda". > >I haven't checked RHEL5. If we can't rely on scsi_id to work the same way >across udev releases, then we could just pick a version of the code and >copy it into libvirt tree, stripping it down to only the function we >actually need. It isn't that much code and doing that's probably easier >than playing games with a tool that changes its calling conventions With the caveat that it is GPLv2, not LGPLv2.