Re: [PATCH v2 1/1] remote: properly initialize objects in ACL helpers

On Tue, Mar 19, 2024 at 15:07:04 +0100, Denis V. Lunev wrote: > Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to > implement two things: reduce stack usage inside ACL helpers and > minimally initialize virDomainDef object to avoid passing garbage > inside validation framework. Though original commit has not > touched other ACL helpers. > > This patch adds proper clauses to > remoteRelayNetworkEventCheckACL > remoteRelayStoragePoolEventCheckACL > remoteRelayNodeDeviceEventCheckACL > remoteRelaySecretEventCheckACL > > Signed-off-by: Denis V. Lunev <den(a)openvz.org&gt; > CC: Peter Krempa <pkrempa(a)redhat.com&gt; > CC: Roman Grigoriev <rgrigoriev(a)astralinux.ru&gt; I'll drop the CC lines if you are okay with that as it doesn't seem to be needed to record that info in git. > --- > src/remote/remote_daemon_dispatch.c | 32 ++++++++++++++--------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > Changes from v1: > * g_autoptr is replaced with g_autofree upon reached consensus > * patch 1 in series has been dropped Reviewed-by: Peter Krempa <pkrempa(a)redhat.com&gt; and I'll push it after the release is done later today.