Re: [libvirt] [PATCH] qemu: multiqueue for ccw devices
On 05/06/2015 11:35 AM, Boris Fiuczynski wrote:
On 05/06/2015 05:32 PM, Laine Stump wrote:
> On 05/06/2015 11:20 AM, Boris Fiuczynski wrote:
>> On 05/06/2015 05:02 PM, Laine Stump wrote:
>>> On 05/06/2015 10:07 AM, Boris Fiuczynski wrote:
>>>>> Allow ccw devices to be used with multiqueues.
>>> Can you provide a bit more information in the commit log on the reason
>>> for this difference? Is the vectors= option not supported when
>>> using the
>>> ccw bus? Or is is simply not needed because it's determined
>>> automatically based on the number of fd's that are passed in?
>>>
>>>
>> Sure and sorry about the short commit log.
>> ccw provides a one to one relation of fds to queues and does not
>> support the vectors option.
>>
>
> Okay, ACK.
>
> I'll just add that sentence to the commit log message and push it. No
> need to respin.
>
> Thanks!
>
Laine,
please also cleanup the line
Reviewed-by: Cornelia Huck <cornelia.huck(a)de.ibm.comCornelia Huck
<cornelia.huck(a)de.ibm.com>>
which I accidentally screwed up.
Sure. I also just noticed while running "make syntax-check" that you
called virBufferAsprintf() on a string with no format characters; I'm
replacing that with a call to virBufferAddLit().