On 10/20/19 2:55 PM, Ján Tomko wrote:
Note that VIR_STRDUP is still defined at the end of this series,
due to sharing a test with VIR_STRNDUP.
Removing VIR_STRNDUP will require some extra care, since GLib's
g_strndup does not accept a length of -1 as an alias for acting
like g_strdup.
Ján Tomko (34):
scripts: introduce a macro file for coccinelle
util: fix check for iscsi initiator copy
conf: use g_strdup in virDomainDiskSet
Use g_strdup instead of ignoring VIR_STRDUP's value
Use g_strdup instead of ignoring VIR_STRDUP_QUIET's value
drivers: use g_strdup in probe functions
Use g_strdup where VIR_STRDUP's return value was propagated
Use g_strdup to fill in default values
bhyve: use g_strdup instead of VIR_STRDUP
conf: use g_strdup instead of VIR_STRDUP
cpu: use g_strdup instead of VIR_STRDUP
datatypes: use g_strdup instead of VIR_STRDUP
esx: use g_strdup instead of VIR_STRDUP
interface: use g_strdup instead of VIR_STRDUP
libxl: use g_strdup instead of VIR_STRDUP
locking: use g_strdup instead of VIR_STRDUP
logging: use g_strdup instead of VIR_STRDUP
lxc: use g_strdup instead of VIR_STRDUP
network: use g_strdup instead of VIR_STRDUP
node_device: use g_strdup instead of VIR_STRDUP
nwfilter: use g_strdup instead of VIR_STRDUP
qemu: use g_strdup instead of VIR_STRDUP
remote: use g_strdup instead of VIR_STRDUP
rpc: use g_strdup instead of VIR_STRDUP
security: use g_strdup instead of VIR_STRDUP
storage: use g_strdup instead of VIR_STRDUP
test: use g_strdup instead of VIR_STRDUP
virstorage: use g_strdup instead of VIR_STRDUP
vircgroup: use g_strdup instead of VIR_STRDUP
util: use g_strdup instead of VIR_STRDUP
vbox: use g_strdup instead of VIR_STRDUP
tests: use g_strdup instead of VIR_STRDUP
tools: use g_strdup instead of VIR_STRDUP
Use g_strdup instead of VIR_STRDUP everywhere
Should we have 35/34 which drops VIR_STRDUP.* macros and extend
hacking.html? If so, you can count with my ACK on it too.
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal