
4 Mar
2014
4 Mar
'14
5:52 p.m.
On 03/04/2014 07:13 AM, Martin Kletzander wrote:
1) Would helper function (macro) be preferred so the code looks cleaner?
What macro do you have in mind?
I haven't thought that through, just from top of my head:
#define SESSION_UNSUPP(what) if (!cfg->privileged) { \ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s %s", \ what, _("is not available in sesison mode")); \
That's not very nice to translators. At this point, what you started with is better than what a macro would give. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org