Re: [libvirt] [PATCH RFC] helper of copy-storage-* features

On Sun, Oct 21, 2012 at 7:53 PM, liguang <lig.fnst(a)cn.fujitsu.com&gt; wrote: > help to create disk images copy-storage-* required, > try to do non-shared migration without bothering to > create disk images at target by hand. >

> + } else > + cmd = virCommandNewArgList("rm", "-f", def->disks[i]->src, NULL); > + > + if (virCommandRun(cmd, NULL) < 0) { > + goto cleanup; > + virReportSystemError(errno, "%s", > + _("unable create disk images by qemu-img")); > + } The error message reported doesn't match what happened when the rm -f fails. Also 'cmd' is being leaked here.