Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses
On 02/09/2016 10:59 AM, Cole Robinson wrote:
We use the PreFormat callback for this. Many test cases need to be
extended
to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors.
One test case (pcie-root-port-too-many) is dropped, since it was meant
only for checking an error condition in qemuxml2argv, and one we add in
AssignAddresses it errors here too.
I forgot to comment about this by the time I got to the end of reviewing
- does this mean the error is no longer checked? My recollection is that
test was meant to check the path where someone defines more
pcie-root-port controllers than will fit on pcie-root (which is the only
place you can attach a pcie-root-port). It obviously works now, but if
the code was broken and someone tried to add in too many pcie-root-ports
(because they wanted all their devices off of pcie-root rather than
adding some other kind of bridge/switch) they would get a rude surprise
(I know that's all highly unlikely to happen, but...