Re: [PATCH v2] qemu: passt: add support for custom command line arguments

On Thu, Jul 10, 2025 at 08:39:18 +0200, Enrique Llorente Pastora wrote: > On Thu, Jul 10, 2025 at 7:55 AM Peter Krempa <pkrempa(a)redhat.com&gt; wrote: > > > > On Wed, Jul 09, 2025 at 15:44:15 +0200, Enrique Llorente Pastora wrote: > > > I have pushed a v3 with all the fixes for v2, clearly v2 was kind of > > > half baked, sorry about that. > > > > Before I reply to v3 I still want you to reply at least to my question > > about how the test result (.args) file ended up referencing '-drive'. > > > > I see there are some references of drive at > tests/qemuxmlconfdata/disk-serial.x86_64-latest.args, since > I used some kind of LLM to generate the tests I suppose it took > inspiration from it. Okay, what other parts of the code did you use AI tools for?

> At v3 I ditched the generated test confdata and used a version from > tests/qemuxmlconfdata/net-user-passt.x86_64-latest.args > that adds the passt:commandline. Since we use golden/snapshot tests it's easy to generate the output files: VIR_TEST_REGENERATE_OUTPUT=1 ./tests/qemuxmlconftest https://www.libvirt.org/advanced-tests.html