Re: [libvirt] [PATCH v2 06/14] libxl: handle missing switch enum cases
On Wed, Feb 21, 2018 at 10:35:04AM +0100, Martin Kletzander wrote:
On Tue, Feb 20, 2018 at 05:08:14PM +0000, Daniel P. Berrangé wrote:
> Cast away enum type for libxl schedular constants since we don't want to
s/schedular/scheduler/
> cover all of them and don't want build to break when new ones are added.
>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
> src/libxl/libxl_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index be11134fb2..4b52de36f5 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -4497,7 +4497,7 @@ libxlDomainGetSchedulerType(virDomainPtr dom, int *nparams)
>
> if (nparams)
> *nparams = 0;
> - switch (sched_id) {
> + switch ((int)sched_id) {
We should get consistent with the spacing after cast and add it to HACKING.
This way I can't tell you to add a space there =)
Adding a space between a typecast and a variable is a-typical in general,
so I don't see why we should do it for switch() statements.
> case LIBXL_SCHEDULER_SEDF:
> name = "sedf";
> break;
> --
> 2.14.3
>
> --
> libvir-list mailing list
> libvir-list(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|