Re: [libvirt] [PATCH 0/5] Another attempt at improving virsh autocompletion
On 03/29/2014 08:36 PM, Solly Ross wrote:
This patch set represents yet another attempt to improve the virsh
autocompletion. When writing this patch, I tried to take into account
the comments on the previous attempt at autocompletion by Tomas Meszaros.
Nice - I'm hoping you can get it all the way!
Specifically, it was reccomended that any completion use the existing
methods that virsh has in place to parse the partial line being completed.
Also recommended was to enhance the testsuite to prove that we have
implemented things correctly, as well as to add a new virsh command that
can be reused from the shell to make writing the shell completer easier
(the two are intricately related - our testsuite will use the same
completer as the shell would use). However...
outgoing/0000-cover-letter.patch | 68 +
...prove-virsh-autocompletion-extract-parser.patch | 428 ++++++
...prove-virsh-autocompletion-base-framework.patch | 278 ++++
...ve-virsh-autocompletion-global-ctl-object.patch | 116 ++
...ove-virsh-autocompletion-domain-completer.patch | 1479 ++++++++++++++++++++
...virsh-autocompletion-enum-completer-macro.patch | 131 ++
tools/Makefile.am | 3 +-
tools/virsh-completer.c | 353 +++++
tools/virsh-completer.h | 86 ++
tools/virsh-domain-monitor.c | 287 +---
tools/virsh-domain.c | 72 +
tools/virsh-snapshot.c | 11 +
tools/virsh.c | 517 +++++--
tools/virsh.h | 13 +
14 files changed, 3447 insertions(+), 395 deletions(-)
...I see no mention of a testsuite change. While I don't mind reviewing
the patches, I'm unwilling to accept them into the tree without a
testsuite and a 'virsh complete' command that the shell can use to hook
into the completion engine.
https://www.redhat.com/archives/libvir-list/2013-September/msg01029.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)