Re: [libvirt] [PATCH v2 0/2] FS backend VolCreateXMLFrom implementation.
Daniel Veillard wrote:
On Mon, May 18, 2009 at 01:30:31PM -0400, Cole Robinson wrote:
> The following 2 patches implement virStorageVolCreateXMLFrom for the
> storage driver and the FS storage backend.
>
> Changes from v1:
> - Mark origvol as building in driver implementation
> - Make sure driver is locked when relocking pool object
> - Simplify sparse file detection with memcmp
> - Allocate read buffer on the heap.
>
> Thanks,
> Cole
>
> Cole Robinson (2):
> Storage driver implementation for CreateXMLFrom
> VolumeCreateXMLFrom FS storage backend implementation.
Okidoc, both patches looks fine, ACK !
Daniel
Thanks, I've pushed both now.
- Cole