Re: [PATCH libvirt-dbus 1/3] src: fix double free of virDomain object
On Wed, 2020-06-24 at 16:17 +0100, Daniel P. Berrangé wrote:
The virDomainSnapshotGetDomain() method does NOT increment the
refcount on the returned virDomain, so it must not be unrefed.
This double free is responsible for random failures of the
test_snapshot.py tests.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/domainsnapshot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Nice!
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization