Eric Blake wrote:
On 10/22/2013 06:29 AM, Jim Fehlig wrote:
On systems where gnutls uses libgcrypt, I'm seeing the following build failure
libvirt.c:314: error: variable 'virTLSThreadImpl' has initializer but incomplete type libvirt.c:319: error: 'GCRY_THREAD_OPTION_PTHREAD' undeclared here (not in a function) ...
Fix by undefining WITH_GNUTLS_GCRYPT in config-post.h
Signed-off-by: Jim Fehlig <jfehlig@suse.com> ---
Although I'm more confident in this fix vs the previously reported virt-login-shell build failure, I'd still prefer an ACK before pushing.
I'm not sure on the other one yet, but can definitely ACK this one.
Thanks, I pushed this one. Michal pushed the other one that Daniel ACKed. One thing that concerned me, which I forgot to mention in the mail or commit message, was this comment above libvirt_setuid_rpc_client in src/Makefile.am # Since virt-login-shell will be setuid, we must do everything # we can to avoid linking to other libraries. Regards, Jim