Re: [libvirt] [PATCH v3 07/11] livirt: Move URI alias matching to util
On Fri, Nov 06, 2015 at 12:46:22PM +0100, Erik Skultety wrote:
As we need to provide support for URI aliases in libvirt-admin as
well, URI
alias matching needs to be internally visible. Since
virConnectOpenResolveURIAlias does have a compatible signature, it could be
easily reused by libvirt-admin. This patch moves URI alias matching to util,
renaming it accordingly.
This illustrates the reason why we should not have the same libvirt.conf
file used by both libvirt.so and libvirt-admin.so. The URIs you need to
pass to libvirt-admin.so are a different scheme from the URIs you need
to pass to libvirt.so. So we don't want the same uri_aliases conf parameter
mixing up 2 different sets of URIs. So we definitely need a separate
libvirt-admin.conf file
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|