Re: [libvirt] [cim][PATCH 1/2] Fix memory leak in set_other_id_info
On 12/18/2017 02:31 PM, John Ferlan wrote:
Looks OK; however, there hasn't been a non build related source
code
change to libvirt-cim since June 2014. So while this could be pushed,
I'm curious to understand why the "sudden interest" in CIM? The last
release was July 2013!
I'm not sure there is any sudden interest in CIM, but few users have
noticed the slow memory leak. It's better to have this fixed.
Perhaps if you'd generated a --cover-letter with your git
send-email to
explain that would have helped. See https://libvirt.org/hacking.html for
some general patch submission guidelines when there's more than one
patch in a series, although for libvirt-cim perhaps only the first
section applies as virtually none of the code formatting and naming
would apply...
> John
OK, thank you for the tips.
I've updated the patch, as you suggested, to affect less lines of code.
- Adam