7 Mar
2019
7 Mar
'19
7:58 a.m.
On Wed, Mar 06, 2019 at 17:54:02 +0100, Andrea Bolognani wrote:
Despite its name, this is really just a general-purpose string manipulation function, so it should be moved to the virstring module and renamed accordingly.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/conf/virsecretobj.c | 2 +- src/conf/virstorageobj.c | 2 +- src/libvirt_private.syms | 2 +- src/util/virfile.c | 17 ----------------- src/util/virfile.h | 4 ---- src/util/virstring.c | 17 +++++++++++++++++ src/util/virstring.h | 3 +++ 7 files changed, 23 insertions(+), 24 deletions(-)
ACK. Although you could also fix the return value type when at it.