Re: [libvirt] [PATCH] build: fix virBufferVasprintf on mingw
On 07/01/2011 07:50 AM, Eric Blake wrote:
But now we have a problem - if gnulib did _not_ replace snprintf
because
it probed the mingw version and found that the return value was correct,
then the libintl override violates gnulib's assumptions. If gnulib
_does_ replace snprintf, but does not support %1$d, then gnulib violates
libintl's assumptions.
One bit of good news - I confirmed (by modifying test-vsnprintf, then
testing on mingw64, where the gnulib replacement _does_ kick in) that
gnulib's vsnprintf replacement supports %1$d out of the box without any
further m4 tests, and without having to drag in the vsnprintf-posix
module. So at this point, the patch for mingw is as simple as ensuring
that the gnulib snprintf replacement always kicks in. Proposed patch
coming up soon.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)