Re: [libvirt] [PATCH] Fix > 1 char device for qemu VM
On Mon, Sep 29, 2008 at 12:45:15PM -0400, Cole Robinson wrote:
Trying to start a qemu guest with more than 1 character
device (serial or parallel, doesn't count for console)
always times out. There was an error in the code that
would strip the pty path qemu spits out, which
confused the parsing after being called more than twice.
The attached patch fixes this. I verified that guests
with 0, 1, and 2 serial devices all boot fine.
ACK.
At some point we really need to create a fake QEMU binary / monitor
console for the test suite to allow coverage of this code
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|