Re: [libvirt] [PATCH RFC] virhook: Adding inotify support to virhook.
On 13.09.2016 02:25, Julio Faracco wrote:
Hi guys,
As I mentioned, we are working in a project that introduces a hook for QEMU.
And when someone installs the RPM/DEB package with this hook,
we need to restart the libvirtd service everytime. It is really
annoying for users.
Well, RPM packages have %post macro where package maintainer can put
some scripts. Well, commands to run. For instance:
/bin/systemctl try-restart libvirtd.service >/dev/null 2>&1 || :
can be there. I bet DEB packages have similar option.
In my opinion, we can include an #if and #else to compile with inotify support.
But, I don't see any good reason to add.
Well, one of the reasons might be that other systems than Linux where
libvirt is built would fail after this patch. inotify is Linux specific
and for instance *BSD kernels don't have it. So we need to check for it
in configure phase.
Michal