Re: [libvirt] [PATCH 09/15] tests: qemucaps: Temporarily remove 'query-qmp-schema' from test data
On 10/20/2016 10:25 AM, Peter Krempa wrote:
Remove the command from the supported commands list temporarily so
that
QMP introspection code can be added without breaking tests and having to
tweak the test data in the same commit.
This will be later reverted and test data will be added. The aarch64
code is special as it calls additional commands and thus the test data
can't be added upfront.
Again, goes back to my complaint that the replies files are too fragile;
they need more context (what command triggered what reply), and no 'id'
field (since it makes any change in the middle of the sequence harder on
the rest of the file). And again, not the thing for THIS patch to be
fixing.
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)