Re: [libvirt] [PATCH v2 3/3] disk: Force clearing of the first 2048 bytes of device prior to mklabel

On Fri, Apr 07, 2017 at 09:52:09 -0400, John Ferlan wrote: I'm not a fan of this and neither thing this is robust enough: The problem here is that apparently the "mac" table fits into the first block on the disk. Since the GPT disklabel is stored at LBA address 1 it is not overwritten at all. Thus it's apparent that the detection tool then prefers GPT over a older disklabel. The GPT disklabel has also a secondary copy at the last LBA of the disk. As for robustness: SECTOR_SIZE is defined as 512 in our code, thus this code nukes 2k of data. For devices with 4k sectors which are already available this won't help at all, since LBA 0 will still contain the protective MBR, and the 3,5k left of LBA 0 will be unused. GPT disklabel still will start at LBA 1. Since I'm not a fan of similar code when nuking physical volumes I'd rather not see this stuff to spread.