Re: [libvirt] [PATCH 00/11] Generic data stream handling

On Tue, Sep 15, 2009 at 02:35:02PM +0200, Chris Lalancette wrote: > I've uploaded the code that I'm trying out at the moment to: > > http://gitorious.org/~clalance/libvirt/clalance-staging/commits/tunnelled... > > Dan, can you take a look and make any suggestions about where I might be going > wrong? I've not look at your migration code yet, but there's a mistake in your change to the test driver. http://gitorious.org/~clalance/libvirt/clalance-staging/commit/e77dc1f1ba... The test driver is delibrately not using saferead/write because those helpers do not handle EAGAIN. If you get EGAIN they'll return -1 and you are left with no idea how much data you've written which is not helpful :-) At very least this will cause the stream to terminate with an error message. If I got something wrong, perhaps its causing a crash.