Re: [libvirt] PATCH: 17/25: Concurrent client dispatch in libvirtd

"Daniel P. Berrange" <berrange@redhat.com> wrote: ...

Finally I've also made use of ssize_t as suggested, this also made me notice one place where we didn't propagate the EAGAIN case of ret=0 correctly.

I compared our two patched versions and it all looks fine. It's good that you made those s/4/REMOTE_MESSAGE_HEADER_XDR_LEN/ changes, too. One final nit: ...

+static struct qemud_client_message * +qemudClientMessageQueueServe(struct qemud_client_message **queue) +{ + struct qemud_client_message *tmp = *queue; + + if (tmp) { + *queue = tmp->next; + tmp->next = NULL; + } else { + *queue = NULL; + }

You can remove that "else" block, since we already know *queue is NULL there.