Re: [RFC PATCH 08/10] hw/misc/vmcoreinfo: Implement 'vmcore-info' object
On 20/12/24 09:50, Marc-André Lureau wrote:
Hi
On Thu, Dec 19, 2024 at 7:39 PM Philippe Mathieu-Daudé
<philmd(a)linaro.org> wrote:
>
> 'vmcore-info' object allow to transition from '-device'
> to 'object', following the deprecation process.
>
Is there a strong motivation behind this? just replacing -device with
-object doesn't really give anything, does it?
No. (Daniel mentioned the same on the cover letter:
https://lore.kernel.org/qemu-devel/2ae4799b-f78d-4fde-becb-9ee7f767e8f1@l...)
Sorry for wasting review cycles.
Also I'd rather keep the name "vmcoreinfo" since
that's how it used to
be, and also the name used by the kernel ELF etc.
> No need to modify VMCoreInfoState since DeviceState
> already inherits from Object state.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org>
> ---
> include/hw/misc/vmcoreinfo.h | 4 ++-
> hw/misc/vmcoreinfo.c | 48 +++++++++++++++++++++++++++++++++++-
> 2 files changed, 50 insertions(+), 2 deletions(-)