Re: [libvirt] [PATCH 3/3] Move virEmitXMLWarning into xml.h
On Fri, Jan 27, 2012 at 10:56:27AM -0700, Eric Blake wrote:
On 01/27/2012 10:37 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> The virEmitXMLWarning function should always have been in
> the xml.[hc] files, and should use virXML as its name
> prefix
>
> * src/util/util.c, src/util/util.h: Remove virEmitXMLWarning
> * src/util/xml.c, src/util/xml.h: Add virXMLEmitWarning
> ---
> src/util/util.c | 39 ---------------------------------------
> src/util/util.h | 4 ----
> src/util/xml.c | 41 ++++++++++++++++++++++++++++++++++++++++-
> src/util/xml.h | 5 +++++
> 4 files changed, 45 insertions(+), 44 deletions(-)
Another mechanical move. ACK with the following changes.
You forgot to also move the function declaration in
libvirt_private.syms. And since no one outside of xml.c calls it, you
might as well make it static and removing both the export in
libvirt_private.syms, as well as:
Oh yes, good idea.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|