Re: [libvirt] Re: [Libvir] [PATCH] Add bus attribute to disk target definition
On Wed, May 07, 2008 at 09:38:26AM +0200, Soren Hansen wrote:
Yes and no. In the latest patch I provided I only set use_extboot if
there's only one boot device defined, and it's a virtio device, so PXE
booting would use the old-style "-boot n" syntax. I literallly woke up
this morning and instantly smacked my forehead due to another problem
this introduced, so I'm happy you changed it. :)
The thing is that you can specify multiple boot devices in the XML to
set a priority, eg
<boot dev="network"/>
<boot dev="hd"/>
Gets maps to '--boot nc' so in this scenario you'd have a virtio device
being bootable, and also have PXE enabled.
Oh, and thanks for doing all the test cases as well. I didn't
want to
get started on those until we had agreed on the logic that should be
applied.
FWIW, I always start with the test cases first defining the XML and QEMU
args, and then write the impl until the test cases pass.
Dan.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|