Re: [libvirt] [PATCH 2/7] Move storage encryption code to src/util
On Fri, Sep 25, 2009 at 02:27:28PM +0100, Mark McLoughlin wrote:
This is so we can use it in the storage file probing code which is
also moving to src/util
The real code change is renaming virStorageReportError() to
virStorageEncryptionReportError()
* src/util/storage_encryption.[ch]: add
* src/conf/storage_encryption_conf.[ch]: remove
* src/conf/domain_conf.h, storage/conf/storage_conf.h: include
storage_encryption.h
* src/Makefile.am: build src/util/storage_encryption.[ch]; note
libvirt_lxc now needs to be linked with $(SELINUX_LIBS)
* proxy/Makefile.am: ditto
* po/POTFILES.in, src/libvirt_private.syms: update
---
po/POTFILES.in | 2 +-
proxy/Makefile.am | 2 +-
src/Makefile.am | 52 +++---
src/conf/domain_conf.h | 2 +-
src/conf/storage_conf.h | 2 +-
src/conf/storage_encryption_conf.c | 294 -----------------------------------
src/conf/storage_encryption_conf.h | 80 ----------
src/libvirt_private.syms | 2 +-
src/util/storage_encryption.c | 301 ++++++++++++++++++++++++++++++++++++
src/util/storage_encryption.h | 80 ++++++++++
NACK, this is really not very desirable - it was intended that there
would be a strict separation between the XML handling code, and general
purpose utility functions, so I'm against moving XML handling code into
util.
I understand why you did this though - the code in storage_backend_fs.c
that you later move into util/ depends on it. I think we should refactor
the latter though, rather than moving this XML handling code
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|