Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device
On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote:
If there is no sound device configured for the guest we can disable
the
audio output because hot-plugging sound devices isn't supported.
Are you sure about that. While libvirt may not have wired up ability to
hotplug sound devices, I'm pretty sure that QEMU is able to hotplug
them.
Ff libvirt forceably disables the audio backend, now, and then future
libvirt enables the pre-existing QEMU support for hotplug, existing VMs
will be doomed.
IOW, I don't think this patch is desirable.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|