v10:
http://www.redhat.com/archives/libvir-list/2016-October/msg00866.html
Changes since v10...
This is essentially the adding the secret to/for the TLS chardev TCP. Lots
of messy stuff.
Patches 1-3 are new... In particular, I kept looking at the RNG removal
code and kept thinking, something just doesn't look right when compared
to the RemoveVirtioDisk code. If I'm incorrect with order of removal it's
an easy enough change. Kept trying to think what depends on what and for
the RNG it would seem a need a to unplug the backend before removing the
front end object would be more logical.
Patches 4-5 are the old patch 3-4. They (hopefully) encompass the previous
review plus other things since discovered.
John Ferlan (5):
qemu: Move TLS object remove from DetachChr to RemoveChr
qemu: Swap order of RNG hot unplug removal
qemu: Need to remove TLS object in RemoveRNGDevice
qemu: Add a secret object to/for a char source dev
qemu: Add secret object hotplug for TCP chardev TLS
src/qemu/qemu_command.c | 30 +++-
src/qemu/qemu_command.h | 1 +
src/qemu/qemu_domain.c | 173 +++++++++++++++++-
src/qemu/qemu_domain.h | 17 +-
src/qemu/qemu_driver.c | 6 +-
src/qemu/qemu_hotplug.c | 195 +++++++++++++++++----
src/qemu/qemu_hotplug.h | 9 +-
src/qemu/qemu_process.c | 9 +-
tests/qemuhotplugtest.c | 2 +-
...xml2argv-serial-tcp-tlsx509-secret-chardev.args | 38 ++++
...uxml2argv-serial-tcp-tlsx509-secret-chardev.xml | 50 ++++++
tests/qemuxml2argvtest.c | 17 ++
12 files changed, 495 insertions(+), 52 deletions(-)
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.xml
--
2.7.4