Re: [libvirt] [PATCH] Support QEMU/KVM watchdog device

On Wed, Oct 21, 2009 at 01:32:49PM +0100, Richard W.M. Jones wrote: > + if ((n = virXPathNodeSet(conn, "./devices/watchdog", ctxt, &nodes)) < 0) { > + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, > + "%s", _("cannot extract watchdog devices")); > + goto error; > + } Hum, I'm afraid this will lead to errros for any defintition without a watchdog ! Since that's completely optional we really should not error there IMHO and just skip it.

As well as extending the domain.rng as you raised on IRC :-)