Re: [libvirt] [PATCH] maint: Fix use of invalid reboot flags
On Wed, Nov 28, 2012 at 05:39:21PM +0100, Michal Privoznik wrote:
Throughout the code, we've always used VIR_DOMAIN_SHUTDOWN*
flags
even for virDomainReboot() API and its implementation. Fortunately,
the appropriate macros has the same value. But if we want to keep
things consistent, we should be using the correct macros. This
patch doesn't break anything, luckily.
---
Worth backporting to v0.10.2-maint and v0.9.11-maint (will cause conflict)?
Given that it is harmless, I don't think its worth the bother
The v0.9.6-maint doesn't have these flags yet.
src/libvirt.c | 4 ++--
src/qemu/qemu_driver.c | 8 ++++----
tools/virsh-domain.c | 4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|