Re: [libvirt] [PATCH v3 44/48] util: change identity class attribute names
On Tue, 2019-07-30 at 16:23 +0200, Christophe de Dinechin wrote:
Daniel P. Berrangé writes:
> virTypedParamsAddString(&tmpparams, nparams, &maxparams,
> VIR_CLIENT_INFO_UNIX_USER_NAME,
There are some spots where "UNIX" remains...
That's because VIR_CLIENT_INFO_UNIX_* are pre-existing defines which,
since they're part of the public API, can't be changed without
breaking existing applications.
It is true, however, that we're basically introducing a whole new set
of defines where VIR_CLIENT_INFO_* already cover exactly the values
we want to pass around... Is there any way we can reuse those instead
of coming up with our own ever so slightly different set of defines?
--
Andrea Bolognani / Red Hat / Virtualization