Re: [libvirt] [PATCHv4 15/18] blockjob: accommodate RHEL backport names
On 04/09/2012 09:52 PM, Eric Blake wrote:
RHEL-only
drive-mirror and drive-reopen are still under upstream qemu
discussion; as a result, RHEL decided to backport things under
a downstream name. Accommodate this alternate spelling. I
don't think it's worth trying to support both spellings at once:
if you build upstream libvirt on RHEL, you lose out on the
feature, but then you are also capable of building upstream qemu
for RHEL to reinstate the feature (that is, if you use RHEL, you
should either stick to the distro patches, or you are assumed to
be capable of building the entire virt stack yourself).
* src/qemu/qemu_monitor_json.c (qemuMonitorJSONCheckCommands):
Check for alternate spelling.
(int qemuMonitorJSONDriveMirror, qemuMonitorJSONDriveReopen): Use
that spelling.
---
src/qemu/qemu_monitor_json.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
Just a heads-up for those following this thread:
Paolo reposted a proposal for the 'drive-mirror' job that might make it
into qemu 1.1:
https://lists.gnu.org/archive/html/qemu-devel/2012-04/msg01630.html
In particular, the upstream proposal does _not_ allow for 'drive-mirror'
as part of transaction; that would have to wait for qemu 1.2. As a
result, my earlier proposal for supporting snapshot+mirror is not
possible with the upstream qemu 1.1 proposal:
https://www.redhat.com/archives/libvir-list/2012-March/msg01033.html
However, the backport of __com.redhat_drive-mirror into RHEL 6.3 was
based on the earlier versions that were proposing the blkmirror driver
instead of a block job implementation, and since snapshot+mirror was
first developed against a potential RHEL build, Paolo has made an effort
to keep things working there, so I am still maintaining that patch
series and will post a rebase of the series on top of my blockjob
patches. Of course, the snapshot+mirror won't be committed upstream
without upstream qemu support, but at least it will provide a comparison
between the two live storage migration proposals, as well as something
that could still be backported to RHEL.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)