Re: [PATCH 00/28] a bunch of domain_conf cleanup
On a Monday in 2020, Michal Privoznik wrote:
On 11/6/20 4:32 AM, Matt Coleman wrote:
>Most of this is making functions void that unnecessarily return an int.
>It also includes some conversion to GLib.
>
>Feel free to squash related commits, if you'd like. I left them separate
>to make it easier to review.
>
Yeah, some might be squashed.
> 14 files changed, 158 insertions(+), 296 deletions(-)
>
Nice cleanup. But as I say in 03/28 I think we might want glib
adoption to be done in bigger chunks.
Of course a bulk rewrite to g_free would get rid of VIR_FREE faster.
But this series is about int -> void conversion. I think it's perfectly
fine to include minor fixes you notice while doing that.
No need to shave the whole yak [0] :)
Jano
[0] https://en.wiktionary.org/wiki/yak_shaving#Noun
Usually we rewrite
VIR_ALLOC/VIR_REALLOC_N -> g_new0()/g_renew() in one patch (might be
coupled with g_free() except VIR_FREE() resets the pointer to NULL and
g_free() doesn't do that so I'm not really a fan of g_free()), then
g_strdup() in another path, and so on.
Michal
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)