Re: [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()
On 09/03/2015 01:40 PM, Jim Fehlig wrote:
Remove redundant error reporting in libxlDomainMigrationPerform().
virNetSocketNewConnectTCP() is perfectly capable of reporting
sensible errors.
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
V2:
Actually try to compile the code and find saved_errno is no
longer used - remove it.
src/libxl/libxl_migration.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
ACK
John
Also noteworthy that virNetSocketNewConnectTCP could overwrite errno
when freeaddrinfo is run in error: or when VIR_FORCE_CLOSE() did it's
thing...