Re: [libvirt] [PATCH v2] build: silence a clang warning in virsh.c
On 11/18/2013 09:03 AM, Eric Blake wrote:
>> The warning happens because rl_readline_name on Mac OS X is
still
>> 'char *', while it is 'const char *' on most platforms.
>
> This is the real bug we are working around, not clang.
>
Again, I think it's better to call out the faulty version of libreadline
with the problem, rather than which compiler chokes on it.
I did some history digging. bash.git is not the world's friendliest git
repository (Chet insists on one mega commit per release rather than
individual commits per logical change, although he's at least gotten
better at weekly patches rather than waiting for major releases) - but
in spite of that, it only took me about 10 minutes to prove that
rl_readline_name was introduced non-const in bash 2.0.1 (and its
corresponding readline version 2.1 in June 1997) and made const in bash
2.0.5 (and its corresponding readline version 4.2, released in Apr
2001). Sheesh, is MacOS really using something older than readline 4.2,
just because they are anti-GPLv3?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)