Re: [libvirt] [PATCH] openvz_conf.c: remove dead store to "p"; use strchrnul
Jim Meyering wrote:
I may separate this into two commits.
Currently we can't use the part that adds the strchrnul use,
since gnulib's module lists its license as LGPL, which
means LGPLv3+, and that conflicts with libvirt's LGPLv2+ requirement.
However, since strchrnul is derived from glibc, it should be easy
to adjust that. I've asked the maintainer of that module on the
bug-gnulib list. We'll see later today when the US wakes up.
The licenses of the strchrnul module and its dependent, rawmemchr,
have been relaxed to LGPLv2+, so to get that updated in gnulib,
I've added a preceding commit that adjusts libvirt's .gnulib
submodule to use latest commit from upstream gnulib.
With that, autogen.sh notices the change and automatically
runs ./bootstrap.
I confirmed that "make check" passes all tests.
>From b76bc73df65c793958ce646fd80763c19a9e4dbd Mon Sep 17 00:00:00
2001
From: Jim Meyering <meyering(a)redhat.com>
Date: Tue, 8 Sep 2009 11:07:32 +0200
Subject: [PATCH] openvz_conf.c: remove dead store to "p"; use strchrnul
* src/openvz_conf.c (openvzReadNetworkConf): Replace open-coded
while loop with equivalent use of strchrnul.
* bootstrap (modules): Add strchrnul.