Re: [libvirt] [PATCH v2.1 18/21] limit cpu bandwidth only for vcpus
On Tue, Aug 21, 2012 at 05:18:41PM +0800, Hu Tao wrote:
This patch changes the behaviour of xml element cputune.period
and cputune.quota to limit cpu bandwidth only for vcpus, and no
longer limit cpu bandwidth for the whole guest.
The reasons to do this are:
- This matches docs of cputune.period and cputune.quota.
- The other parts excepting vcpus are treated as "emulator",
and there are separate period/quota settings for emulator
in the subsequent patches
The real question is if this is actualy a change of behaviour.
I think it is, but without doing this this gets quite hard to
effectively control separately the usage for the hypervisor threads
versus those of the guests.
This is also the point of that large patch set ... so ACK based
on the fact that people saw that coming and won't disagree with that
possible small change in the control.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/