Re: [libvirt] [PATCH 4/n] spec: default vbox according to libvirtd build
On 09/04/2013 07:22 AM, Michal Privoznik wrote:
On 04.09.2013 04:56, Eric Blake wrote:
> Commit ba5f3c7 moved virtualBox support into libvirtd, but the spec
> file was still unconditionally requesting it even when not building
> the server side. This leads to the weird result of building
> libvirt-client and libvirt-daemon-lxc rpms when client_only is
> requested (via manual edit, or via RHEL 5 on s390).
Further testing proved my hypothesis wrong - all of the
libvirt-daemon-vbox conditionals were already protected by the master
with_libvirt conditional, so having with_vbox set to 1 on a client-only
build didn't have any negative impact. But this patch doesn't hurt, and
still makes sense from a cleanliness point of view, so...
>
> * libvirt.spec.in (with_vbox): Hoist to server conditionals.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
ACK
I've gone ahead and pushed it with an updated commit message.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)