Re: [libvirt] [PATCH] cpustat: fix regression when cpus are offline

On 10/25/12 22:57, Eric Blake wrote: > It turns out that the cpuacct results properly account for offline > cpus, and always returns results for every possible cpu, not just > the online ones. So there is no need to check the map of online > cpus in the first place, merely only a need to know the maximum > possible cpu. Meanwhile, virNodeGetCPUBitmap had a subtle change > from returning the maximum id to instead returning the width of > the bitmap (one larger than the maximum id), which made this code > encounter some off-by-one logic leading to bad error messages when > a cpu was offline: >

virBitmapPtr map = NULL; > - virBitmapPtr map2 = NULL; When you apply this patch "map" is also not needed (never actualy used). Is there a way to replace "map = nodeGetCPUBitmap(domain->conn, &max_id);" to get max_id? That's the only thing that code is used to. > int rv = -1; > int i, id, max_id; > char *pos; Otherwise looks good. (ACK if there isn't any other option to get max_id than to call nodeGetCPUBitmap)