Re: [libvirt] libvirt-java

On Mon, Jul 07, 2008 at 08:26:53PM +0200, Toth Istvan wrote: Okay, I have tried to look at this I ended up with the enclosed patch. I had a couple of assumptions to do: - CredentialType would still be a subtype of Credential - adressing from the GetMethodID() and FindClass() would need org/libvirt/VirConnectAuth$Credential instead of org/libvirt/VirConnectCredential and org/libvirt/VirConnectAuth$Credential$CredentialType instead of org/libvirt/VirConnectCredential$VirConnectCredentialType i.e. two $ lookups yeah that sounds fine to me hopefully patched accordinly this still works yeah, I think we can get rid of the Vir prefix for everything, except the enums, where it's probably better to keep them. This mimics what have been done in other bindings too. I would come up with a patch too easilly but I first want an initial review on the Credential refactoring if this looks good I will first commit that one and then as a second step provide a Vir elimination patch (which will be big since everything will be modified) Once that done, after a bit of testing I guess I will make a 0.2.0 release and push that one to Fedora, sounds right ? thanks, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/