Re: [PATCH 4/6] tools: secure guest check on s390 in virt-host-validate

19 May 2020


      ...
...
...
...
+
+    virHostMsgCheck(hvname, "%s", _("for secure guest support"));
+    if (ARCH_IS_S390(arch)) {
We don't need ^this check here, facility 158 won't be available on x86.
Since it is very true that the facility 158 won't be available on x86 you do
not want to get the message "Hardware or firmware does not provide support
for IBM Secure Execution" on x86.
On the other hand you can be on s390 and not have the facility available and
want to know see the message.
Oops, I missed the last nested else block, please ignore what I said then.

-- 
Erik Skultety