Re: [PATCH v5 00/18] *** qemu: block: Support block disk along with throttle filters ***
On Mon, Nov 18, 2024 at 19:24:08 +0530, Harikumar R wrote:
*** BLURB HERE ***
Chun Feng Wu (17):
schema: Add new domain elements to support multiple throttle groups
schema: Add new domain elements to support multiple throttle filters
config: Introduce ThrottleGroup and corresponding XML parsing
config: Introduce ThrottleFilter and corresponding XML parsing
qemu: monitor: Add support for ThrottleGroup operations
tests: Test qemuMonitorJSONGetThrottleGroup and
qemuMonitorJSONUpdateThrottleGroup
remote: New APIs for ThrottleGroup lifecycle management
qemu: Refactor qemuDomainSetBlockIoTune to extract common methods
qemu: Implement qemu driver for throttle API
qemu: helper: throttle filter nodename and preparation processing
qemu: block: Support block disk along with throttle filters
config: validate: Verify iotune, throttle group and filter
qemuxmlconftest: Add 'throttlefilter' tests
test_driver: Test throttle group lifecycle APIs
virsh: Refactor iotune options for re-use
virsh: Add support for throttle group operations
virsh: Add option "throttle-groups" to "attach_disk"
Harikumar Rajkumar (1):
tests: Test qemuxmlactivetestThrottleGroup
The review is done now. There are few bits.
Please note that I didn't point out *all* places needing a version
number update, so make sure to check everything explicitly. Please use
11.1.0 for next posting.
One important bit is that IMO the getter API makes IMO no sense to be
added as the data can simply be queried from the XML. Having a special
API is a bit overkill.
Few other things I've pointed out:
- some coding style issues
- some pointless comments