Re: [libvirt] [libvirt-tck] [RFC] 802.1Qbg test scripts
On Wed, 2010-10-06 at 12:52 +0100, Daniel P. Berrange wrote:
I don't like this approach. JUst add an optional parameter
to the build_domain methods
my $mode = @_ ? shift : "bridge";
eg so it default to traditional bridging, but you can pass
in 'vepa' if you desire to change it. Or something like
that.
Thanks for the feedback. The changes are in the attached new versions of
the patches. It would be great if you could push at least
modify_library_functions.patch to the git.
--
Best regards,
Gerhard Stenzel,
-----------------------------------------------------------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
Attachments:
- modify_library_functions.patch (text/x-patch — 3.4 KB)
- add_vsitype_testcase.patch (text/x-patch — 1.8 KB)