Re: [libvirt] [PATCH] python: prefer PyList_SET_ITEM to PyList_SetItem
Giuseppe Scrivano <gscrivan(a)redhat.com> writes:
Martin Kletzander <mkletzan(a)redhat.com> writes:
> Oh, you're right. I was blinded by the fact, that PyList_SetItem()
> checks whether the 'op' is a list and I was under the impression that
> PyList_Check(op) will catch that. This has not yet changed (I checked
> 3.3.2), so you're right, the fact that we'll use PyList_SET_ITEM won't
> change a thing. I'll continue with the review in a minute. Thanks
> for the idea.
If you already worked on the review, then I can split these
additional
changes and rebase them.
I'll send these changes as a separate series.
Giuseppe