On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote:
I'm curious why we're trying to replace fseeko impl at all,
since I
would expect the modern glibc impl to be suitable to use as-is.
It's to work around glibc bug#12799, a longstanding bug with ungetc and
fflush. See the bug-gnulib thread that starts here:
https://lists.gnu.org/r/bug-gnulib/2009-01/msg00067.html
Any chance of getting that glibc bug fixed in glibc 2.28? That should
avoid the problem with Gnulib, and would be a good thing in its own
right. In the meantime, the attached Gnulib patch is intended to work
around the bug from the Gnulib side; does it work for you? (I haven't
tried it on rawhide.)