Re: [libvirt] [PATCH v2 07/38] iohelper: Remove unused mode
On 04/20/2017 06:01 AM, Michal Privoznik wrote:
After 1eb6647979f8c nobody calls the iohelper with 6 arguments.
Everybody uses the other mode. Well, the only user of iohelper
after the previous commit is virFileWrapperFd really.
Are we talking two commits ago? Couldn't this then be merged with that
to make it more obvious with the commit message adjustment indicating
now that the commit is the last consumer/caller of iohelper with so many
arguments. It also shows where you've essentially moved the code.
ACK if I've read properly and this moves...
Still a little concerned over the timing of patch 5 w/r/t release
timing, but I suppose we have a few days for something to pop up.
John
FYI: Going to stop here for now - I'll look to look at the rest in the
morning.