Re: [libvirt] [PATCH v2 0/7] optionally expose disk usage during dumpxml
On Tue, Nov 18, 2014 at 06:31:46AM -0700, Eric Blake wrote:
v1 was here:
https://www.redhat.com/archives/libvir-list/2014-September/msg01077.html
This adds the framework for exposing disk of all disks from a single
dumpxml command. I'm still working on a followup patch to further
list usage of disks in the backing chain, rather than just the
top-level disk, but want to get review started on this code.
I'm not really convinced that exposing disk allocation/capacity
information in the XML is appropriate. The XML is intended as a
representation of the guest hardware API and the host configuration.
The disk allocation/capacity info is neither of those things - it
is a statistic about the current state of the system. THis is
something that we'd usually report via dedicated APIs not the
XML.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|